NightOwl888 commented on code in PR #829:
URL: https://github.com/apache/lucenenet/pull/829#discussion_r1165918115
##########
src/Lucene.Net.QueryParser/Xml/QueryTemplateManager.cs:
##########
@@ -34,20 +35,28 @@ namespace Lucene.Net.QueryParsers.Xml
public class QueryTemplateManager
{
private readonly IDictionary<string, XslCompiledTransform>
compiledTemplatesCache = new Dictionary<string, XslCompiledTransform>(); //
LUCENENET: marked readonly
- private XslCompiledTransform defaultCompiledTemplates;
+ // LUCENENET specific - made protected to allow subclasses to access
and initialize
+ protected XslCompiledTransform m_defaultCompiledTemplates;
Review Comment:
It looks like this was meant to be a "default template" and the user could
subclass to add their own template. To do this they would need to:
1. Override the `public QueryTemplateManager()` constructor.
2. Load their own template. However they want to.
3. Set their own private `XslCompiledTransform` to a private variable.
4. Override `GetQueryAsXmlString` and `GetQueryAsDOM` to supply their
private variable.
Maybe I have missed something, but I don't think there is any advantage to
making this variable protected as it is supposed to represent the "default"
template, not the user specified one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
