NightOwl888 commented on PR #838: URL: https://github.com/apache/lucenenet/pull/838#issuecomment-1518698814
> Not sure how to proceed here. It feels like we either stop using NextInt64 or drop .net5? [NextInt64()](https://github.com/NightOwl888/RandomizedTesting/blob/main/src/RandomizedTesting.Generators/Support/RandomExtensions.cs#L119) is an extension method in RandomizedTesting.Generators. However, I noticed that it doesn't cascade the call to the correct random implementation when the `Random` instance is a `J2N.Randomizer`, which I have submitted a fix for in https://github.com/NightOwl888/RandomizedTesting/pull/1. That won't affect what you are doing, though and we can upgrade RandomizedTesting.Generators later. We most definitely do not want to drop tests for `net5.0` and `net461` as that would leave a gap in our test coverage. Namely, we wouldn't have any tests for the `netstandard2.1` or `netstandard2.0` assemblies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
