laimis opened a new pull request, #847: URL: https://github.com/apache/lucenenet/pull/847
Continuation of fixes with virtual calls being made from constructors. The issue originally reported by SonarCloud scans: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1699&id=apache_lucenenet and referenced in this issue: https://github.com/apache/lucenenet/issues/670 Here we are changing DirectoryTaxonomyWriter to use DirectoryTaxonomyIndexWriterFactory class that will create config and writer. The factor class can be subclassed and a different implementation provided and used by either DirectoryTaxonomyWriter subclasses or just passed to the class itself. The two areas impacted by this: Facets and Replication. Both had a few subclasses that injected custom behavior and were adjusted to use factory approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
