NightOwl888 commented on issue #715: URL: https://github.com/apache/lucenenet/issues/715#issuecomment-1814545466
Sure. This is about accessibility of the members of the anonymous classes to make the members unavailable to the calling code (except for the member variables that are initialized in the constructor). It is less of a concern for members that are part of an interface or base class to make the members private (and in the latter case they must be the same accessibility as the base class), but all of the fields should definitely be hidden from the outside world. We have already done some improvements to the naming conventions of the anonymous classes in #426 and #666 so they all end in the suffix `AnonymousClass`, making them easier to find. #666 also has marked them all `private` and `sealed`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
