NightOwl888 opened a new pull request, #892: URL: https://github.com/apache/lucenenet/pull/892
<!-- Thank you for submitting a pull request to our repo. --> <!-- Please do NOT submit PRs for features in newer versions of Lucene. We should keep the target version consistent across our repository to make the upgrade process to newer versions of Lucene go smoothly. --> <!-- If this is your first PR in the Lucene.NET repo, please run through the checklist below to ensure a smooth review and merge process for your PR. --> - [X] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [X] You've included unit or integration tests for your change, where applicable. - [ ] You've included inline docs for your change, where applicable. - [X] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. <!-- Once all that is done, you're ready to go. Open the PR with the content below. --> Summary of the changes (Less than 80 chars) Added net6.0 target to Lucene.Net.Analysis.OpenNLP and changed to using MavenReference Closes #852, closes #890 ## Description This supersedes and closes #852. It drops the package dependency on [OpenNLP.NET](https://www.nuget.org/packages/OpenNLP.NET), and instead uses `<MavenReference>` to add a dependency on [opennlp-tools](https://central.sonatype.com/artifact/org.apache.opennlp/opennlp-tools/1.9.4). `<MavenReference>` does not add a binary to our distribution (except for IKVM and its dependencies). Instead, it transitively gets added to any SDK-style project that depends on Lucene.Net.Analysis.OpenNLP. Each dependency from Maven is downloaded and converted from bytecode into IL on the user's build machine. This allows the user to add additional `<MavenReference>` dependencies, which will use Maven to resolve any versioning conflicts between common dependencies. More importantly, this ensures that only one copy of each data type exists in the project, which wouldn't be the case with a dependency on OpenNLP.NET. It also allows adding other OpenNLP components as required by the project, rather than having one binary that incorporates all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
