NightOwl888 opened a new pull request, #912: URL: https://github.com/apache/lucenenet/pull/912
<!-- Thank you for submitting a pull request to our repo. --> <!-- Please do NOT submit PRs for features in newer versions of Lucene. We should keep the target version consistent across our repository to make the upgrade process to newer versions of Lucene go smoothly. --> <!-- If this is your first PR in the Lucene.NET repo, please run through the checklist below to ensure a smooth review and merge process for your PR. --> - [x] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [x] You've included unit or integration tests for your change, where applicable. - [x] You've included inline docs for your change, where applicable. - [x] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. <!-- Once all that is done, you're ready to go. Open the PR with the content below. --> Summary of the changes (Less than 80 chars) `Lucene.Net.Search.FieldComparer.TermValComparer`: Fixed sorting ambiguity between empty fields and missing fields ## Description When using `Arrays.Empty<T>()` we get a singleton instance. However, this comparer uses reference equality to compare the static fields `MISSING_BYTES` and `NON_MISSING_BYTES`. This reverts back to `new byte[0]` to ensure the reference equality checks pass. ### BREAKING This PR also adds an internal constructor to `FieldComparer`, since this is a class that we added to make Lucene.NET compile. It is confusing for users who are upgrading because in older versions `FieldComparer` was not a generic class. Users who are upgrading should use `FieldComparer<T>`, which reduces or eliminates the need for casting of the underlying type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
