paulirwin commented on code in PR #938: URL: https://github.com/apache/lucenenet/pull/938#discussion_r1602508557
########## src/Lucene.Net/Support/ConcurrentHashSet.cs: ########## @@ -753,7 +753,16 @@ private void CopyToItems(T[] array, int index) public void ExceptWith(IEnumerable<T> other) { - throw new NotImplementedException(); + if (ReferenceEquals(this, other)) Review Comment: Well, nevermind on the names bit, I encountered the tests that ensure we name them correctly. Fixing now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org