rclabo commented on code in PR #940:
URL: https://github.com/apache/lucenenet/pull/940#discussion_r1643184040


##########
src/Lucene.Net.Tests/Support/Threading/ReentrantLockTest.cs:
##########


Review Comment:
   This file appears it may be a port of a file from OpenJdk. That codebase is 
GNU GPL 2 licensed which is not compatible with the Apache License that appears 
in this file's header. The file needs to be removed from the PR. We should 
create our own ReentrantLockTest class that does not incorporate external code.



##########
src/Lucene.Net/Support/Threading/UninterruptableMonitor.cs:
##########


Review Comment:
   These method should ideally all contain doc comments to explain what they 
do.  



##########
src/Lucene.Net/Index/DocumentsWriterFlushControl.cs:
##########


Review Comment:
   Line 505 contains "flushQueue.Count > 0 &&", which is not found in the 
corresponding Java Lucene 4.8.1 code. This, however, is a pre-existing 
deviation rather than a change submitted in this PR. Still, it may be worth 
investigating why this change was introduced and whether it is still needed.



##########
src/Lucene.Net/Support/Threading/ReentrantLock.cs:
##########


Review Comment:
   These changes to ReentrantLock overall seem like an elegant solution to get 
close to parity to how the reentrantLock class works in Java (as far as I 
understand it based on a bunch of googling). So, in general, this feels like a 
great step forward. It is, however, imperative that the code be original and 
not incorporate any OpenJDK code or code from any non-Apache source. Please 
ensure that is the case. 



##########
src/Lucene.Net.Tests/Support/Threading/JSR166TestCase.cs:
##########


Review Comment:
   On further review this file appears that it may be a port of a file from 
OpenJdk.  That codebase is GNU GPL 2 licensed which is not compatible with the 
Apache License that appears in this file's header.  The file needs to be 
removed from the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to