NightOwl888 commented on code in PR #951:
URL: https://github.com/apache/lucenenet/pull/951#discussion_r1717095645
##########
src/dotnet/Lucene.Net.Tests.CodeAnalysis/Lucene.Net.Tests.CodeAnalysis.csproj:
##########
@@ -22,7 +22,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFramework>net5.0</TargetFramework>
+ <TargetFramework>net6.0</TargetFramework>
Review Comment:
If you are referring to `<IsPublishable>`, MSBuild will set to the last
condition that is met from top to bottom. So, this is a bit like saying this in
C#:
```c#
bool IsPublishable = false;
if (TargetFramework == "net8.0")
{
IsPublishable = true;
}
```
This build code is run for all target frameworks in CI, so we need set it to
`false` for all target frameworks that don't apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
