devklick opened a new pull request, #957:
URL: https://github.com/apache/lucenenet/pull/957

   <!-- Thank you for submitting a pull request to our repo. -->
   
   <!-- Please do NOT submit PRs for features in newer versions of Lucene. We 
should keep the target version consistent across our repository to make the 
upgrade process to newer versions of Lucene go smoothly. -->
   
   <!-- If this is your first PR in the Lucene.NET repo, please run through the 
checklist
   below to ensure a smooth review and merge process for your PR. -->
   
   - [x] You've read the [Contributor 
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code 
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
   - [x] You've included unit or integration tests for your change, where 
applicable.
   - [x] You've included inline docs for your change, where applicable.
   - [x] There's an open issue for the PR that you are making. If you'd like to 
propose a change, please [open an 
issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the 
change or find an existing issue.
   
   <!-- Once all that is done, you're ready to go. Open the PR with the content 
below. -->
   
   Add TryDequeue and TryPeek Queue extension methods
   
   Fixes #954
   
   ## Description
   
   New class created, `QueueExtensions`, with two new methods, `TryDequeue` and 
`TryPeek`. These are compiled based on the `FEATURE_QUEUE_TRYDEQUEUE_TRYPEEK` 
flag. 
   - Inline documentation included
   - Unit tests included 
   
   **Notes:**
   
   One of the requirements on the linked ticket was to update all references to 
use these new functions. I have updated _some_ of them, only where it will 
eliminate a check along the lines of `queue.count > 0 && queue.Dequeue/Peek()`. 
There are more calls to `queue.Dequeue()` and `queue.Peek()` where it did not 
seem suitable to replace with the Try* equivalent, so I have left them as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to