paulirwin commented on PR #960: URL: https://github.com/apache/lucenenet/pull/960#issuecomment-2363997252
@Shazwazza I agree with this change. Even though the upstream Java code uses the abstraction for the field type, we're already deviated from the upstream code by using a set instead of a list. I think this field could use a `// LUCENENET-specific:` comment on it though to note for future porting work. And I'm guessing you saw the build failed, so once that is fixed if you wouldn't mind adding that comment I'd be happy to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
