rclabo opened a new pull request, #963:
URL: https://github.com/apache/lucenenet/pull/963

   <!-- Thank you for submitting a pull request to our repo. -->
   
   <!-- Please do NOT submit PRs for features in newer versions of Lucene. We 
should keep the target version consistent across our repository to make the 
upgrade process to newer versions of Lucene go smoothly. -->
   
   <!-- If this is your first PR in the Lucene.NET repo, please run through the 
checklist
   below to ensure a smooth review and merge process for your PR. -->
   
   - [ ] You've read the [Contributor 
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code 
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
   - [ ] You've included unit or integration tests for your change, where 
applicable.
   - [ ] You've included inline docs for your change, where applicable.
   - [X ] There's an open issue for the PR that you are making. If you'd like 
to propose a change, please [open an 
issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the 
change or find an existing issue.
   
   <!-- Once all that is done, you're ready to go. Open the PR with the content 
below. -->
   
   Summary of the changes (Less than 80 chars)
   
   Fixes #(959): Fix TermStats.TermText access, add CLI comments and 1 CLI bug 
fix
   
   ## Description
   
   1) Converts TermStats.TermText into a public property and changes it's case 
to follow .NET conventions.  
   2) Code sweep of all the Main(args) methods that relate to the lucene-cli so 
they now have XML summary comments that indicate that they are not intended for 
direct use but rather are used by the lucene-cli.   If the Main method is in a 
static class that looks to be designed solely for use from the command line 
then similar comments are added to the class.
   3) In the process of doing the code sweep to add comments, I discovered one 
cli command Lucene,Net.Cli.BenchmarkFindQualityQueriesCommand that was wired up 
to the wrong command class.  So I fixed this bug as well by wiring it up the 
right one which is QualityQueriesFinder.Main(args).
   4) the 4th commit was due to realizing that I had one failing test due to me 
making TermStats.TermText a public field rather than a public property.  So 
this commit fixes that and the failing unit test.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to