paulirwin commented on code in PR #968:
URL: https://github.com/apache/lucenenet/pull/968#discussion_r1792032706
##########
src/Lucene.Net.Replicator/Http/ReplicationService.cs:
##########
@@ -188,24 +188,14 @@ public virtual void Perform(IReplicationRequest request,
IReplicationResponse re
break;
}
}
- catch (Exception e)
+ catch (Exception)
{
response.StatusCode = (int)HttpStatusCode.InternalServerError;
// propagate the failure
- try
- {
- TextWriter writer = new StreamWriter(response.Body);
- JsonSerializer serializer =
JsonSerializer.Create(JSON_SERIALIZER_SETTINGS);
Review Comment:
I removed `JSON_SERIALIZER_SETTINGS` entirely because it's not needed if
we're just using the default and removing TypeNameHandling.
I think we should leave `ExecutePost` as protected for now to match Java's
semantics. It's a now-deprecated type (in Lucene 9.12) anyways, and I don't see
a good reason to break anyone that has already implemented this method even
though it's not being used. I think we can safely leave it as-is.
PR ready for re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
