paulirwin commented on issue #1004:
URL: https://github.com/apache/lucenenet/issues/1004#issuecomment-2447803578

   A few subtle corrections:
   
   > 1.  The docfx tool is already installed, so a dotnet tool restore will 
function
   > 2. The docfx command is on the path
   
   The current version of the script makes neither of these assumptions (apart 
from "so a dotnet tool restore will function." `dotnet tool restore` restores 
any tools in `.config/dotnet-tools.json` as local tools. If `dotnet tool 
restore` is failing, that is not the same thing as assuming that "the docfx 
tool is already installed." 
   
   As for "The docfx command is on the path" - that is definitely not an 
assumption, because of the above. The script was updated to use `dotnet tool 
run docfx` instead of assuming it is on the path. The only thing it assumes is 
on the path is `dotnet`. Did you mean `dotnet` instead of `docfx` in those two 
points?
   
   I agree that we can change the tool path location to be more reliable.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to