NightOwl888 commented on code in PR #996: URL: https://github.com/apache/lucenenet/pull/996#discussion_r1829594881
########## src/Lucene.Net.Expressions/JS/Javascript.g4: ########## @@ -0,0 +1,249 @@ +/* + Javascript.g + An expression syntax based on ECMAScript/Javascript. + + This file was adapted from a general ECMAScript language definition at http://research.xebic.com/es3. + The major changes are the following: + * Stripped grammar of all parts not relevant for expression syntax. + * Stripped grammar of unicode character support. + * Added override function for customized error handling. + * Renaming of many grammar rules. + * Removal of annotations no longer relevant for stripped pieces. + + The Original Copyright Notice is the following: + + Copyrights 2008-2009 Xebic Reasearch BV. All rights reserved.. Review Comment: 3rd party licenses need to be included here (which we are doing), but also need to be appended to the [LICENSE.txt](https://github.com/apache/lucenenet/blob/46f129215af4a074fe3a6659a2d2050b76829db0/LICENSE.txt#L206) file along with a description of which files the license applies to (or partially applies to). https://www.apache.org/legal/release-policy.html#license-file This is more easily caught in a PR than in a release audit, so we should take care of that now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
