paulirwin opened a new pull request, #1033:
URL: https://github.com/apache/lucenenet/pull/1033

   - [X] You've read the [Contributor 
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code 
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
   - [ ] You've included unit or integration tests for your change, where 
applicable.
   - [X] You've included inline docs for your change, where applicable.
   - [X] There's an open issue for the PR that you are making. If you'd like to 
propose a change, please [open an 
issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the 
change or find an existing issue.
   
   Fix incorrect usage of argument exceptions for Sonar csharpsquid:S3928
   
   Fixes #682
   
   ## Description
   
   This addresses a few incorrect usages of various argument exceptions, such 
as missing/incorrect parameter names, using ArgumentOutOfRangeException with a 
parameter name that doesn't exist, missing messages for ArgumentException, and 
so on.
   
   For the analysis factories, these were reverted to be ArgumentException 
because various analysis tools (including Sonar and ReSharper/Rider) complain 
about using a key name for the dictionary when it doesn't exist as a parameter.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to