paulirwin commented on code in PR #1028: URL: https://github.com/apache/lucenenet/pull/1028#discussion_r1849032777
########## src/Lucene.Net.Tests/Analysis/TokenAttributes/TestCharTermAttributeImpl.cs: ########## @@ -326,6 +330,10 @@ public virtual void TestAppendableInterfaceWithLongSequences() const string longTestString = "012345678901234567890123456789"; t.Append(new CharSequenceAnonymousClass(longTestString)); Assert.AreEqual("4567890123456" + longTestString, t.ToString()); + + // LUCENENET specific - test ReadOnlySpan<char> overload + t.SetEmpty().Append("01234567890123456789012345678901234567890123456789".AsSpan()); + Assert.AreEqual("01234567890123456789012345678901234567890123456789", t.ToString()); Review Comment: Good idea, broke those tests out as TestSpanAppendableInterface on both this and TestCharBlockArray. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org