NightOwl888 commented on PR #1036: URL: https://github.com/apache/lucenenet/pull/1036#issuecomment-2486448267
> Looks good, unless we wanted to share EncodingProviderInitializer between the projects in Lucene.Net core. Yeah, I thought of that, but it requires a dependency on `System.Text.Encoding.CodePages`. So, the best we can do to share this is to make it a linked file that does not a belong to any project. There is quite a bit of duplicated code in these analysis projects (for example CSVUtil in kuromoji and nori), so this seems like the trend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
