paulirwin commented on code in PR #1039:
URL: https://github.com/apache/lucenenet/pull/1039#discussion_r1852249118
##########
Directory.Build.targets:
##########
@@ -130,9 +130,9 @@
<DebugType>full</DebugType>
</PropertyGroup>
- <!-- Features in .NET Framework 4.5+ and .NET 6.0+ but not in .NET Standard
2.0 or .NET Standard 2.1 -->
+ <!-- Features in .NET Framework 4.5+ and .NET 8.0+ but not in .NET Standard
2.0 or .NET Standard 2.1 -->
<!-- net472 is used to test .NET Standard 2.0, so we treat it like it is not
part of this group -->
- <PropertyGroup Condition=" ($(TargetFramework.StartsWith('net4')) And
'$(TargetFramework)' != 'net472') Or $(TargetFramework.StartsWith('net6.')) Or
$(TargetFramework.StartsWith('net7.')) Or
$(TargetFramework.StartsWith('net8.')) ">
+ <PropertyGroup Condition=" ($(TargetFramework.StartsWith('net4')) And
'$(TargetFramework)' != 'net472') Or $(TargetFramework.StartsWith('net8.')) Or
$(TargetFramework.StartsWith('net9.')) ">
Review Comment:
Hm, so this was failing because of FEATURE_OPENNLP not working on .NET
Standard 2.1 when compiled against .NET 6, since it only supported 6 and 8
before I dropped the 6 target. Perhaps I should make another PropertyGroup just
for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
