paulirwin opened a new pull request, #1054: URL: https://github.com/apache/lucenenet/pull/1054
- [X] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [X] You've included unit or integration tests for your change, where applicable. - [X] You've included inline docs for your change, where applicable. - [X] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. Fix intermittent failed TestMaxClauseLimitations tests Fixes #1050 ## Description These tests occasionally fail on .NET 8 due to Dynamic PGO optimizing the code and inlining some methods, which changes the stack trace. Instead of harming performance by forcing NoInlining, since this case inspecting the stack trace was only for an assertion rather than changing behavior (as other cases of inspecting the stack trace for specific methods do), this assertion was removed. It should only matter here if the exception is thrown; not which specific method throws it. The `Assert.Fail` above this `catch` explains exactly that, and the original comment was even questioning whether it should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
