NightOwl888 commented on code in PR #1061:
URL: https://github.com/apache/lucenenet/pull/1061#discussion_r1883322501
##########
src/Lucene.Net/Search/NumericRangeQuery.cs:
##########
@@ -446,7 +446,7 @@ public
Int32RangeBuilderAnonymousClass(NumericRangeTermsEnum outerInstance)
this.outerInstance = outerInstance;
}
- public override sealed void AddRange(BytesRef minPrefixCoded,
BytesRef maxPrefixCoded)
+ public override void AddRange(BytesRef minPrefixCoded,
BytesRef maxPrefixCoded)
Review Comment:
`sealed` is how this is declared upstream. I realize it makes no difference
(it isn't possible to inherit an anonymous class), but let's keep the
declaration in sync.
https://github.com/apache/lucene/blob/releases/lucene-solr/4.8.0/lucene/core/src/java/org/apache/lucene/search/NumericRangeQuery.java#L472
##########
src/Lucene.Net/Search/NumericRangeQuery.cs:
##########
@@ -430,7 +430,7 @@ public
Int64RangeBuilderAnonymousClass(NumericRangeTermsEnum outerInstance)
this.outerInstance = outerInstance;
}
- public override sealed void AddRange(BytesRef minPrefixCoded,
BytesRef maxPrefixCoded)
+ public override void AddRange(BytesRef minPrefixCoded,
BytesRef maxPrefixCoded)
Review Comment:
`sealed` is how this is declared upstream. I realize it makes no difference
(it isn't possible to inherit an anonymous class), but let's keep the
declaration in sync.
https://github.com/apache/lucene/blob/releases/lucene-solr/4.8.0/lucene/core/src/java/org/apache/lucene/search/NumericRangeQuery.java#L432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
