NightOwl888 commented on code in PR #1074:
URL: https://github.com/apache/lucenenet/pull/1074#discussion_r1894999183
##########
src/Lucene.Net.TestFramework/Search/ShardSearchingTestBase.cs:
##########
@@ -704,7 +704,7 @@ public override void Run()
{
try
{
- LineFileDocs docs = new LineFileDocs(Random,
DefaultCodecSupportsDocValues);
+ using LineFileDocs docs = new LineFileDocs(Random,
DefaultCodecSupportsDocValues);
Review Comment:
This will force cleanup of the files immediately after running this test,
even if they are extracted to a temp directory. We probably don't want to do
this because it will slow down the tests a lot, or at least we should figure
out how to exclude them from being cleaned up if they are using temp files.
The
[UseTempLineDocsFileRule](https://github.com/apache/lucenenet/blob/85c01412946ed1e2632cd2dfae4c672efd38caba/src/Lucene.Net.TestFramework/Support/Util/UseTempLineDocsFileRule.cs)
is meant to extract and then clean up the files after the entire test project
is finished running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
