paulirwin opened a new pull request, #1083:
URL: https://github.com/apache/lucenenet/pull/1083

   - [X] You've read the [Contributor 
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code 
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
   - [ ] You've included unit or integration tests for your change, where 
applicable.
   - [X] You've included inline docs for your change, where applicable.
   - [X] There's an open issue for the PR that you are making. If you'd like to 
propose a change, please [open an 
issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the 
change or find an existing issue.
   
   Replaces IndexOutOfRangeException use with ArgumentOutOfRangeException when 
thrown from a method rather than an indexer.
   
   Fixes #1023 
   
   ## Description
   
   It is not correct in .NET to use IndexOutOfRangeException to throw 
exceptions from a non-indexer method when an argument is out of range, even if 
that argument is named `index`; that is what ArgumentOutOfRangeException is 
for. Additionally, this has the added benefit of having the `paramName` set to 
know which argument is out of range.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to