paulirwin commented on issue #898: URL: https://github.com/apache/lucenenet/issues/898#issuecomment-2567257919
After reviewing this, I think we should remove this attribute. In Lucene's [TemporaryFilesCleanupRule](https://github.com/apache/lucene/blob/f01152a5909fa6059f4f1d4aeb4e14968ef1d8c2/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java#L2493-L2498), if this annotation is present and removing the temporary files fails, then it just swallows the exception and logs a warning rather than rethrowing. This annotation is only used by some Solr tests in 4.8.1 (no Lucene tests), and is not used in any Lucene tests in latest Lucene master either. The "BugUrl" property is so that when it logs the warning, it can log which bug is tracking the known issue of it not releasing the temporary files. This indicates that it's for buggy tests; not for useful regular test behavior. Since we do not have any tests that fail like this, and there weren't any Lucene tests that fail this way anyways, I think we should remove the attribute from test framework. This does not encourage good habits by just swallowing the exception if any test framework users actually would have a need to use this attribute. IMHO, any users in this situation should either fix the bug, use `[AwaitsFix]` to not attempt to run the test at all, or solve this manually outside of test framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
