paulirwin commented on issue #1077: URL: https://github.com/apache/lucenenet/issues/1077#issuecomment-2571682867
Great! I do not think there is a better option for Namespace and FullName. No worries there. For `.GetType().Name`, perhaps my idea is not the best. It might make maintenance more difficult in the future if the type of the variable changes in later versions of Lucene. My original thinking was that if `x` was a struct or primitive type like `int`, or `string`, or a sealed class type, then it can't be anything else at runtime, so might as well use `nameof` with the type of `x`. There would not be a need to look at the parent classes, because a parent class by definition can't be sealed. But I hadn't considered the maintenance aspect. Unless you think it's worthwhile to do, I'm good with skipping that for now. (Aside: this is where it would be nice if C# had an equivalent of C++'s `decltype` specifier, so we could do `nameof(decltype(x))` to make this a compile-time evaluation, but alas, that's not a thing, yet.) If you feel good that you've captured all occurrences, I look forward to reviewing your PR when you're ready. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
