paulirwin commented on issue #984: URL: https://github.com/apache/lucenenet/issues/984#issuecomment-2574381919
@NightOwl888 I'm reviewing the J2N read-only collections code to make sure I understand, and I'm not sure how this is true: "Each of the read only collections in J2N has a "Default" mode, which kicks in if the type being passed in is a J2N collection, where the rules of structural equality are defined." It appears to me like these go into Default mode if the generic type arguments are a value type, IStructuralEquatable, or string, regardless of the concrete collection type passed in: https://github.com/NightOwl888/J2N/blob/8845a696e2cd3e2ca0752823c779c72aa7f0e5a1/src/J2N/Collections/ObjectModel/ReadOnlyList.cs#L67 This does not seem to be dependent on the collection being a J2N collection. It appears as if passing i.e. a `System.Collections.Generic.List<string>` would meet that criteria for `Default`. Let me know if I'm missing something. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
