NightOwl888 opened a new pull request, #1092: URL: https://github.com/apache/lucenenet/pull/1092
<!-- Thank you for submitting a pull request to our repo. --> <!-- Please do NOT submit PRs for features in newer versions of Lucene. We should keep the target version consistent across our repository to make the upgrade process to newer versions of Lucene go smoothly. --> <!-- If this is your first PR in the Lucene.NET repo, please run through the checklist below to ensure a smooth review and merge process for your PR. --> - [x] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [ ] You've included unit or integration tests for your change, where applicable. - [x] You've included inline docs for your change, where applicable. - [ ] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. <!-- Once all that is done, you're ready to go. Open the PR with the content below. --> Improved error handling and test reporting ## Description This fixes several concerns regarding output during testing: 1. The details of the random test configuration are now output only if the test fails and will appear in the test message directly. This used to be where they appeared in older versions of NUnit and this restores that functionality. 2. Exceptions that were being called in `LuceneTestCase.OneTimeStartUp()` and `LuceneTestCase.OneTimeTearDown()` were not very visible because NUnit doesn't fail the test when they occur there. This changes it from re-throwing exceptions with an additional message to logging to the output. It goes to stderr in all cases except in `OneTimeTearDown()` where something is redirecting it to stdout. Either way, this changes the ADO pipeline to fail the build so we can avoid shipping the test framework with bugs in these methods. 3. Adds a system property named `tests:failontestfixtureonetimesetuperror` that can be used to cause the test framework to fail all of the tests when there is an error in `OneTimeSetUp()`. We may need to revisit this because there are asserts thrown here that users are supposed to see when dependency injection for codecs is not setup correctly. 4. Removes all messages from the `Assert.Pass()` method because this bloats the size of the test logs with no benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
