NightOwl888 opened a new pull request, #1096: URL: https://github.com/apache/lucenenet/pull/1096
<!-- Thank you for submitting a pull request to our repo. --> <!-- Please do NOT submit PRs for features in newer versions of Lucene. We should keep the target version consistent across our repository to make the upgrade process to newer versions of Lucene go smoothly. --> <!-- If this is your first PR in the Lucene.NET repo, please run through the checklist below to ensure a smooth review and merge process for your PR. --> - [x] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [x] You've included unit or integration tests for your change, where applicable. - [x] You've included inline docs for your change, where applicable. - [x] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. <!-- Once all that is done, you're ready to go. Open the PR with the content below. --> Added DisposeAfterSuite/DisposeAfterTest feature to test framework Fixes #1094 ## Description This adds the `LuceneTestCase.DisposeAfterTest()` and `LuceneTestCase.DisposeAfterSuite()` methods to the test framework that exist in Lucene 4.8.0. It also removes the `LuceneTestCase.SuiteFailureMarker` property that wasn't implemented. NUnit already tracks the result state of the tests in `NUnit.Framework.Internal.TestExectionContext.CurrentContext.TestResult.ResultState` and `NUnit.Framework.TestContext.CurrentContext.Result.Outcome` in a context-sensitive and thread safe manner, so there is no need to reinvent the wheel with this. For the same reason, we don't need the `TestFailureMarker` property or `TestRuleMarkFailure` class, which are all part of this feature. The new feature also revealed that there were some directories that were not being disposed in `Lucene.Net.Tests.Grouping` which were also addressed. For some reason `TestFsts.TestRealTerms()` does not reliably cleanup its line file docs temp file on Windows, so this adds the `[SuppressTempFileChecks]` attribute to suppress the issue when it happens (for now). At some point we should have a look at this, but it is not a blocker for the release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
