paulirwin opened a new pull request, #1113: URL: https://github.com/apache/lucenenet/pull/1113
- [X] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [ ] You've included unit or integration tests for your change, where applicable. - [ ] You've included inline docs for your change, where applicable. - [X] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. Removes the SystemConsole class from Lucene.NET. Related: #920, #936 ## Description #920 had an item for adding unit tests for SystemConsole, but after discussion with @NightOwl888, we determined that this class is not needed in Lucene.NET, and only serves as an unnecessary abstraction. Users that wish to override the Console.Out/Error behavior can use Console.SetOut or Console.SetError to replace them with a different TextWriter. Most of the usage is in tests anyways, and the usage in non-test code is behind VERBOSE flags. #936 raised an issue with MAUI support, but this was only a problem with Console.In. Console.Out and Console.Error work fine in MAUI. This is a breaking change because SystemConsole was previously public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
