paulirwin commented on code in PR #1119: URL: https://github.com/apache/lucenenet/pull/1119#discussion_r1925748976
########## src/Lucene.Net/Support/Threading/LimitedConcurrencyLevelTaskScheduler.cs: ########## @@ -208,10 +203,17 @@ protected sealed override IEnumerable<Task> GetScheduledTasks() } } - // Stops this TaskScheduler from queuing new tasks. + /// <summary> + /// Stops this TaskScheduler from queuing new tasks. + /// </summary> public void Shutdown() Review Comment: I think that could be worthy of discussion in #1080 and very relevant there holistically. This PR just brings over the Harmony tests, and I haven't changed any Shutdown behavior yet. I'd say let's split that out as part of #1080 feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org