paulirwin opened a new pull request, #1121: URL: https://github.com/apache/lucenenet/pull/1121
- [X] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). - [X] You've included unit or integration tests for your change, where applicable. - [X] You've included inline docs for your change, where applicable. - [X] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue. Adds unit tests for the Arrays class from Apache Harmony, removes `Arrays.ToString<T>(T[], IFormatProvider)` Fixes #1114 ## Description This adds the tests from Apache Harmony for many of the Arrays methods, and creates some Lucene.NET-specific tests for the remaining methods. During writing these tests, I went to write a test for `Arrays.ToString<T>(T[], IFormatProvider)` using `fr-FR` as the culture so that it would produce something different than the invariant culture, and it produced problematic output. i.e. passing `new float[] { 1.1f, 2.2f }` results in the string `"[1,1, 2,2]"` due to that culture's decimal comma. This is clearly invalid output, as you cannot tell the difference between the list delimiter and the decimal comma. I looked into what Java does, and it does not have such an overload. It always uses the invariant format with a decimal point, even if your current locale is set to one with a decimal comma. Given that this method was only used in one place, to build a debugging/diagnostic string in FacetResult, I figured that it would be better to match Java's behavior here and remove this overload, using the invariant culture instead. This way we don't have to create tests for what is certainly buggy behavior that is only used in one pl ace in our codebase and only for diagnostic purposes. Additionally, this invariant output more closely matches what you would write in code as well, better catering the output for that purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
