jeme commented on issue #747: URL: https://github.com/apache/lucenenet/issues/747#issuecomment-2653290240
As far as the first item goes, I do think it supports HTTPS already. But you need to use the Constructor overload that takes the full URL rather than the one taking host+port+path. -> https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.Replicator/Http/HttpReplicator.cs#L47 I could only find this that hardcodes http: https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.Replicator/Http/HttpClientBase.cs#L142 Which is specifically used when the HttpReplicator or HttpClientBase is constructed as: `new HttpReplicator("myhost", 9999, "api/repl")` but it should be fine to use "new HttpReplicator("https://myhost:9999/api/repl";) instead I think. (Did not test it now) It would ofc. be possible to add the "scheme" as a parameter for the first constructor so https can be target with that constructor as well, in that case I would probably make it an optional parameter that defaulted to either "http" or "https". Technically I don't think there is anything wrong with http as a default for locally connected nodes within a firewalled network, but I don't have anything against defaulting to https either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
