NightOwl888 commented on code in PR #1131:
URL: https://github.com/apache/lucenenet/pull/1131#discussion_r1964879391
##########
src/Lucene.Net.Tests/Support/Threading/TestLimitedConcurrencyLevelTaskScheduler.cs:
##########
@@ -95,7 +95,13 @@ public void TestGetActiveCount()
unexpectedException();
}
- assertEquals(1, p2.GetActiveCount());
+ // LUCENENET specific - this test is flaky because the thread may
not have started yet
+ // was: assertEquals(1, p2.GetActiveCount());
+ if (p2.GetActiveCount() != 1)
Review Comment:
Let's use `AssumeTrue()` here instead of a condition and
`Assert.Inconclusive()`.
##########
src/Lucene.Net.Tests/Support/Threading/TestLimitedConcurrencyLevelTaskScheduler.cs:
##########
@@ -127,7 +133,13 @@ public void TestGetCompletedTaskCount()
unexpectedException();
}
- assertEquals(1, p2.GetCompletedTaskCount());
+ // LUCENENET specific - this test is flaky because the thread may
not have finished yet
+ // was: assertEquals(1, p2.GetCompletedTaskCount());
+ if (p2.GetCompletedTaskCount() != 1)
Review Comment:
Let's use `AssumeTrue()` here instead of a condition and
`Assert.Inconclusive()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
