paulirwin opened a new pull request, #1132:
URL: https://github.com/apache/lucenenet/pull/1132

   - [X] You've read the [Contributor 
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code 
of Conduct](https://www.apache.org/foundation/policies/conduct.html).
   - [ ] You've included unit or integration tests for your change, where 
applicable.
   - [ ] You've included inline docs for your change, where applicable.
   - [X] There's an open issue for the PR that you are making. If you'd like to 
propose a change, please [open an 
issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the 
change or find an existing issue.
   
   Use J2N methods instead of StringBuilder.Remove
   
   Fixes #664
   
   ## Description
   
   See #664 for details. In one case, the Remove/Insert was not able to be 
replaced with Replace and that was noted with a comment. Also, use of the 
pattern `sb.Remove(0, sb.Length)` was replaced with `sb.Clear()` instead of 
`sb.Delete(0, sb.Length)`, as it is more semantically understandable, less 
prone to mistakes, and has a few less checks internally than `Delete` cascading 
to `Remove` so it should be a little more efficient.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to