NightOwl888 commented on code in PR #1134: URL: https://github.com/apache/lucenenet/pull/1134#discussion_r1987507824
########## src/Lucene.Net.TestFramework/Codecs/Lucene3x/PreFlexRWTermVectorsFormat.cs: ########## @@ -54,11 +54,12 @@ protected internal override bool SortTermsByUnicode() // to each possible target of the StackTraceHelper. If these change, so must the attribute on the target methods. if (StackTraceHelper.DoesStackTraceContainMethod("Merge")) { - unicodeSortOrder = false; - if (LuceneTestCase.Verbose) - { - Console.WriteLine("NOTE: PreFlexRW codec: forcing legacy UTF16 vector term sort order"); - } + // LUCENENET TODO: This does not seem to be hit, unused? Review Comment: Okay. Given that this is the test framework and it is also testing legacy 3.x functionality, I would say this is probably not that important if it is not working in Java, either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org