paulirwin commented on code in PR #1058:
URL: https://github.com/apache/lucenenet/pull/1058#discussion_r1997271571


##########
src/Lucene.Net/Analysis/TokenStream.cs:
##########
@@ -36,13 +37,13 @@ namespace Lucene.Net.Analysis
     /// A new <see cref="TokenStream"/> API has been introduced with Lucene 
2.9. this API
     /// has moved from being <see cref="Token"/>-based to <see 
cref="Util.IAttribute"/>-based. While
     /// <see cref="Token"/> still exists in 2.9 as a convenience class, the 
preferred way
-    /// to store the information of a <see cref="Token"/> is to use <see 
cref="Attribute"/>s.
+    /// to store the information of a <see cref="Token"/> is to use <see 
cref="System.Attribute"/>s.

Review Comment:
   This was added by Rider as part of a refactoring, I should have caught it 
before submitting the PR. However, note that not only is it incorrect _now_, it 
was _previously_ incorrect as well, which is why Rider fully qualified the name 
here. You can see this yourself at the beta 17 docs, where that link goes to 
MSDN for `System.Attribute`: 
https://lucenenet.apache.org/docs/4.8.0-beta00017/api/core/Lucene.Net.Analysis.TokenStream.html
   
   This problem has been there since the beta00005 docs! If it weren't for this 
accidental refactoring, we might not have caught it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to