NehanPathan opened a new pull request, #1149:
URL: https://github.com/apache/lucenenet/pull/1149

   ---
   
   ### Summary of the changes 
   Moved `CrankyTokenFilter` to the correct namespace `Lucene.Net.Analysis`.
   
   ---
   
   ### ๐Ÿ“ **Fixes**  
   Fixes [#1127](https://github.com/apache/lucenenet/issues/1127)
   
   ---
   
   ### ๐Ÿ“š **Description**  
   This pull request addresses issue 
[#1127](https://github.com/apache/lucenenet/issues/1127) by moving 
`CrankyTokenFilter` from the incorrect namespace:
   
   - **Old Namespace:** `Lucene.Net.TestFramework.Analysis.CrankyTokenFilter`  
   - **New Namespace:** `Lucene.Net.Analysis`
   
   โœ… **Details:**
   - Updated the `CrankyTokenFilter` class to reside in the 
`Lucene.Net.Analysis` namespace, aligning it with the correct package as in the 
original Lucene project (`org.apache.lucene.analysis`).
   - Ensured that the class remains in the **TestFramework project** and was 
not moved to `Lucene.Net.Analysis.Common`.
   - Adjusted any necessary using statements and references.
   
   ---
   
   ### ๐Ÿงช **Tests**  
   - Unit tests covering `CrankyTokenFilter` have been run successfully.
   - Verified that all tests related to this change pass without regression.
   
   ---
   
   ### ๐Ÿ“š **Documentation**  
   - Updated inline comments where necessary to reflect the namespace change.
   - No public-facing documentation changes required.
   
   ---
   
   ### ๐ŸŽฏ **Checklist**  
   - [x] I've read the [[Contributor 
Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md)](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md)
 and [[Code of 
Conduct](https://www.apache.org/foundation/policies/conduct.html)](https://www.apache.org/foundation/policies/conduct.html).
   - [x] Unit/integration tests were added or updated.
   - [x] Verified no breaking changes were introduced.
   
   ---
   
   ### ๐Ÿ”ฅ **Ready to Merge!**  
   This change ensures that the project structure remains consistent with the 
original Lucene package, maintaining correctness and improving maintainability.
   
   Thank you for reviewing! ๐Ÿ˜Š๐Ÿš€


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to