NehanPathan commented on code in PR #1154:
URL: https://github.com/apache/lucenenet/pull/1154#discussion_r2035915481
##########
src/Lucene.Net.Tests.Analysis.SmartCn/Lucene.Net.Tests.Analysis.SmartCn.csproj:
##########
@@ -62,5 +62,10 @@
<ItemGroup Condition=" '$(TargetFramework)' == 'net472' ">
<PackageReference Include="System.Text.Encoding.CodePages"
Version="$(SystemTextEncodingCodePagesPackageVersion)" />
</ItemGroup>
+ <ItemGroup>
+ <EmbeddedResource Include="Resources\bigramdict.dct" />
Review Comment:
---
[@paulirwin ]
Hi Paul,
Thanks for pointing that out.
Initially, Git didn’t detect the filename case change (`Dict` → `dict`)
because I’m working on a case-insensitive filesystem (Windows). Even though I
had renamed the files locally, Git was still tracking them with the original
casing.
To resolve it, I followed the two-step rename workaround using a temporary
name, which forced Git to recognize the change. The files are now properly
renamed to `bigramdict.dct` and `coredict.dct`, and the casing in the repo
matches what’s used in the `.csproj`.
Everything should now work correctly on case-sensitive systems too.
Let me know if there’s anything else to fix!
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
