NightOwl888 commented on code in PR #1163:
URL: https://github.com/apache/lucenenet/pull/1163#discussion_r2173158506
##########
src/Lucene.Net.Analysis.Common/Analysis/Miscellaneous/StemmerOverrideFilter.cs:
##########
@@ -105,7 +105,7 @@ public sealed class StemmerOverrideMap
/// <summary>
/// Creates a new <see cref="StemmerOverrideMap"/> </summary>
/// <param name="fst"> the fst to lookup the overrides </param>
- /// <param name="ignoreCase"> if the keys case should be ingored
</param>
+ /// <param name="ignoreCase"> if the keys case should be ignored
</param>
Review Comment:
We should probably report/fix this upstream.
https://github.com/apache/lucene/blob/releases/lucene/10.2.2/lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/StemmerOverrideFilter.java#L105
> I noticed Lucene was the 3rd project to request help, so this would be
right up your alley.
##########
src/Lucene.Net.Analysis.Common/Analysis/Miscellaneous/StemmerOverrideFilter.cs:
##########
@@ -337,4 +337,4 @@ public virtual StemmerOverrideMap Build()
}
}
}
-}
\ No newline at end of file
+}
Review Comment:
I think we need to set up an `.editorconfig` rule (or similar) here.
@paulirwin submits PRs which add a line break to the end of each touched file
and this is now removing them again.
Looks like the changes that were put in are only effective if using
Reshaper, but we need to make this consistent across IDEs. I don't have a
preference and am fine with adding the extra line break at the end of the file.
https://github.com/apache/lucenenet/commit/3729f4ce8a9a456588ffd7888c1238e75864f11f
After fixing the `.editorconfig` setup, there should be a single PR to fix
line endings and whitespace removal solution-wide so we don't have so much
noise during future PR reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
