NightOwl888 commented on PR #866: URL: https://github.com/apache/lucenenet/pull/866#issuecomment-3257567130
@paulirwin FYI - I made a first attempt at doing this in https://github.com/NightOwl888/SPDX.CodeAnalysis/pull/7 using the MSBuild files responsible for managing the `PackageReference`s and versions as a cache key. The cache works, but I tried to bump some of the packages and it didn't bust the cache (yet). This was only the first attempt, though. The cache key is also versioned so it can be busted manually. I will keep working on it, but doing it this way eliminates the need to 1. Manually build locallly to generate a `.lock` file 2. Manually commit the `.lock` file We are already managing the version info in the solution. Creating a lock file means extra maintenance because we are managing the version info in 2 different places (which can go out of sync). ------------------ I also switched it from the `dependencies.props` approach to using Central Package Management. https://github.com/NightOwl888/SPDX.CodeAnalysis/pull/5 This feature eliminates the need to specify the version of `PackageReference` anywhere but in the `Directory.Packages.props` file, and even allows upgrading transitive dependencies without polluting the projects with extra `PackageReference`s. It has been supported since the .NET 6 SDK, so we need to review to make sure we aren't installing the .NET 5 SDK anywhere before we can make the switch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
