NightOwl888 commented on code in PR #1066:
URL: https://github.com/apache/lucenenet/pull/1066#discussion_r1996686567
##########
src/Lucene.Net.Grouping/BlockGroupingCollector.cs:
##########
@@ -342,15 +341,15 @@ public BlockGroupingCollector(Sort groupSort, int
topNGroups, bool needsScores,
/// <param name="fillSortFields">
/// If true then the Comparable values for the sort fields will be set
/// </param>
- public virtual ITopGroups<object> GetTopGroups(Sort withinGroupSort,
int groupOffset, int withinGroupOffset, int maxDocsPerGroup, bool
fillSortFields)
+ public virtual TopGroups<object> GetTopGroups(Sort withinGroupSort,
int groupOffset, int withinGroupOffset, int maxDocsPerGroup, bool
fillSortFields)
Review Comment:
Do we need this overload? It is not called anywhere except one doc comment.
This was `TopGroups<?>` upstream, but we already have a generic overload below.
If we do ultimately need this, I would suggest making an
`IBlockGroupingCollector` interface with the definition on it so it is similar
to the other `object` overloads we have created.
##########
src/Lucene.Net.Grouping/Function/FunctionDistinctValuesCollector.cs:
##########
@@ -53,7 +53,7 @@ public FunctionDistinctValuesCollector(IDictionary /*Map<?,
?>*/ vsContext, Valu
}
}
- public override IEnumerable<GroupCount> Groups => new
JCG.List<GroupCount>(groupMap.Values);
+ public override IList<GroupCount> Groups => new
JCG.List<GroupCount>(groupMap.Values);
public override void Collect(int doc)
{
Review Comment:
The cast to `ISet<MutableValue>` is no longer required on line 64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
