NightOwl888 commented on PR #1197: URL: https://github.com/apache/lucenenet/pull/1197#issuecomment-3366707350
@mmafrar I understand your frustration. Often when we scope issues, we don't have all of the requirements (or don't consider all of them) at the time the issue is created. #1185 focused on the Apache policy requirements, not on the technical or legal concerns of our setup. I reviewed this and it seems there is a precedent for how to deal with binary files without committing them to this repo. We host those directly on https://github.com/apache/lucenenet-site and then use absolute URLs to link to them (so they will always appear when building locally). - Binary images: https://github.com/apache/lucenenet-site/tree/asf-site/images - Binary font files: https://github.com/apache/lucenenet-site/tree/asf-site/fonts So, the simplest solution is to open a PR on that repository so we can move the files there. Once the files are there, they will be available at the https://lucenenet.apache.org/ URL (in the same directory structure as the repo). This means you will get credit for **2 separate PRs** just for fixing this one issue. > NOTE: For now, we can forgo the package manager option that I mentioned earlier for the sake of expediency. ## Legal Concerns AFAIK, we don't have legal permission to host the book images on our website. So, for now, let's leave this out of this fix and continue linking to the broken images until we get that worked out. Unfortunately, there are sometimes conflicting requirements like these that require more time to get through than what should be a "simple" fix, but there is no reason to penalize you for that. If you wish to help us navigate this, then please do by all means. However, it doesn't seem fair to add this as a requirement for this task after you have already submitted a PR. So, when this PR is completed, either we should keep #1185 open to deal with the book images separately, or we should tag this PR with `hacktoberfest-accepted` so you get the credit and then update this PR after we work out the legal issues with the book images. ## Conclusion So, to finish up this task: 1. Fork the asf-site branch of https://github.com/apache/lucenenet-site 2. Clone the fork locally 3. Check out the asf-site branch 4. Create a branch based off of the asf-site branch for your PR 5. Copy the font files into the fonts/ directory 6. Push your local branch to your fork and open a PR at https://github.com/apache/lucenenet-site/pulls 7. Wait for us to review and accept the PR 8. Remove the binary files from this branch (all images and fonts) 9. Change the links to the images back to the originals 10. Change the links to the font files to use https://github.com/apache/lucenenet-site/fonts 11. Fixup any additional things that may be broken by having the files hosted in 2 different places 12. Let us know when it is ready for review Please keep any .js and .css files in this repository, as it will make deployment simpler if we do it manually. > NOTE: I don't know for certain whether all references to the font files can be updated without changing 3rd party .css or .js files. Ideally, we wouldn't change 3rd party files, but patch them by adding additional .css or .js files to update these references. Let us know if you run into any snags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
