NightOwl888 commented on code in PR #2:
URL:
https://github.com/apache/lucenenet-codeanalysis-dev/pull/2#discussion_r2392104354
##########
rat.ps1:
##########
@@ -30,7 +30,7 @@
directory as this script) as the target directory.
.PARAMETER Version
- The version of Apache RAT to use (default: 0.13).
+ The version of Apache RAT to use (default: 0.16.1).
Review Comment:
Okay, I couldn't recall so I went back to check. The issue I was having was
that the RAT tool would hang and not finish. I am guessing that had to do with
the escaping issues that you have already fixed.
Here is what ChatGPT had to say about 0.16:
> That makes sense — RAT 0.13 and RAT 0.16 behave differently:
>
>* **0.13** has the `--addLicense` and `--force` options (which auto-inserts
missing license headers).
>* **0.16** dropped those options and focuses purely on
**auditing/reporting**, not modifying source files. So when you ran with 0.16,
it hung waiting for input because those flags weren’t valid anymore.
>
>That explains why your exclusions format still worked (the syntax hasn’t
changed much), but the run never finished under 0.16.
>
>So your options are:
>
>1. **Stick with 0.13 for release prep** (since it gives you auto-insert).
>2. **Use 0.16** if you only want auditing, but then you’ll need a separate
process to add headers (for example, Apache Yetus’s `addlicense` or manual
templates).
>
>Given this is ASF release prep, using **0.13 just for release managers** is
fine, as long as you document the requirement in your `rat.ps1` header comments.
>
>👉 Do you want me to update your script’s **header doc block** to explicitly
call out that it’s pinned to RAT 0.13 because newer versions removed
auto-insert? That’ll save future contributors from getting confused.
But, either ChatGPT is wrong or the [RAT command-line
docs](https://creadur.apache.org/rat/apache-rat/index.html) are wrong, because
it still shows `--addLicense` and `--force` as options.
Is it adding the licenses to the files with the new version? If not, I would
say let's stick with 0.13. But it is fine to upgrade to 0.16.1 if that still
works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
