paulirwin commented on code in PR #1222:
URL: https://github.com/apache/lucenenet/pull/1222#discussion_r2554470265
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,11 +24,10 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net8.0</TargetFrameworks>
- <RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
+ <TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
+ <RollForward>Major</RollForward>
Review Comment:
Agreed re: net9.0, but the condition doesn't make sense to me. The condition
only applies at compile time, and with setting `TargetFrameworks` to
`net10.0;net8.0` it will only ever be net10.0 or net8.0. So setting the
RollForward to apply only to net10.0 and net8.0 is the same as not having the
condition at all and having it always apply.
That said, I'll make that change for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
