On 11/04/2012 19:09, Marvin Humphrey wrote:
On Tue, Apr 10, 2012 at 12:00 PM, Nick Wellnhofer<[email protected]>  wrote:
The attached patch contains are a rough attempt to initialize the VTables at
run-time.

Looks great, +1 to commit!

Miscellaneous notes:

   * cfish_bootstrap_parcel() will need a per-parcel name, I think.

Yes, but I couldn't find a way to get the parcel name from the CFCBind* classes. It looks like it's only available to the CFCPerl* classes.

   * In VTable_bootstrap, why not just have self->name be an ordinary CharBuf
     rather than a ViewCharBuf?  OH!  HAHAHA!  Not bootstrapped yet! XD

It could also be a CharBuf, but the object has to be created manually, since the VTables aren't set up yet.

I also tried to malloc the VTables dynamically, but this broke
RAWPOSTING_BLANK where a VTable is used to initialize a global struct.

I've just committed a change that kills off RAWPOSTING_BLANK.

I suspect that the ZombieCharBuf EMPTY is also going to get in your way; I'll
look into deep-sixing that one later today.

There may be others; we'll just address them one-by-one until we can malloc
dynamically.

OK.

Nick

Reply via email to