Nick, Thanks for the feedback and good catch on that oversight :). I agree with that I'll make that change.
Thanks, Logan On Tue, Jun 12, 2012 at 4:25 AM, Nick Wellnhofer <[email protected]>wrote: > On 09/06/2012 00:19, Logan Bell wrote: > >> Thanks Nick/Marvin for the suggestions and feedback. I implemented the >> approach that Marvin outlined and it seems to fix the problem for me. >> >> The patch is available here: >> https://issues.apache.org/**jira/secure/attachment/** >> 12531455/potential_fix2.patch<https://issues.apache.org/jira/secure/attachment/12531455/potential_fix2.patch> >> >> Let me know if this seems like a more reasonable hack. >> > > It's reasonable, but it seems that after calling > CC_set_warnings_as_errors(0), error_flag won't be reset to "". Maybe > CC_set_warnings_as_errors should set error_flag directly. > > Nick >
