On Thu, Dec 27, 2012 at 10:20 AM,  <[email protected]> wrote:
> Start using CFCUtil_sprintf

> Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/ffbcad3d

Very nice patch!

I also enjoyed this one, which not only removed bulk but improved readability:

    Replace CFCUtil_cat with CFCUtil_sprintf where appropriate

    Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/013d28ec

> Branch: refs/heads/cfc-sprintf

I've reviewed the whole branch.  Sooooo great, +1 to merge!

The only question I had was whether _scprintf is available under MSVC6. (It's
at least available back to MSVC 2003.)  I figure since you were the one that
did the MSVC6 compatibility work you wouldn't torpedo yourself, but even if it
wasn't there I'd find it really hard to object to this branch.

>  17 files changed, 168 insertions(+), 477 deletions(-)

Net minus 309!!

Marvin Humphrey

Reply via email to