Silly question. A change like this to the public API. Would this cause every host binding to *have* to be updated at the same time to support it?
-Dan On Jan 16, 2013, at 8:11 AM, Marvin Humphrey <[email protected]> wrote: > Greets, > > Dag Lem proposes to add delete_by_doc_id() to Indexer. Since this means > a change to the public API, I'm forwarding the message to the Lucy dev list. > > Deleting by doc id is something of an expert feature. I'm not clear on what > the specific use case is and there may be workarounds, but I can certainly > imagine how it would come up from time to time. I doubt that the underlying > implementation is likely to need changing any time soon, so I don't think this > addition limits our flexibility much. > > Indexer is a high-profile public class and we would like to keep its API > small, so another approach would be to expose the DeletionsWriter > subcomponent. However, IMO document deletion is central enough to Indexer's > purpose to justify top-level convenience methods. > > +1 from me for adding delete_by_doc_id() to Indexer. > > Marvin Humphrey > > ---------- Forwarded message ---------- > From: Dag Lem <[email protected]> > Date: Wed, Jan 16, 2013 at 7:14 AM > Subject: [lucy-user] Add delete_by_doc_id to Lucy::Index::Indexer > To: [email protected] > > > Hi, > > While attempting to modify an index I found that I missed a function > to delete a document by it's ID through Lucy::Index::Indexer (only > delete_by_term and delete_by_query are available). > > Please find attached a patch - is this OK for inclusion? > > -- > Best regards, > > Dag Lem > <Lucy-0.3.2-delete_by_doc_id.patch>
