On Thu, May 2, 2013 at 8:12 AM, Nick Wellnhofer <[email protected]> wrote:
> +1 for CAPTURE/RELEASE, then.
OK, cool... Since it's primarily a naming change but disruptive, I'd suggest
the following order of actions:
1. Grep for `INCREF` and `Inc_RefCount` and make sure all invocations capture
the returned reference.
2. Implement immutable String.
3. Make the naming change.
>> For String, though, it seems like one internal encoding matching the
>> primary host encoding ought to suffice.
>
> This should work. But for the Python bindings, it would mean to use the
> Python encoding for every Clownfish string, even if it isn't passed to the
> Python side at all. And what about the on-disk index? Since it probably
> should always use UTF-8, most strings passed to and from Python have to be
> reencoded anyway. So we could as well use UTF-8 for all Clownfish Strings.
Hmm. Well, the most incremental strategy is to hard-code UTF-8 into String
for now and the Python bindings can just forego the stack-allocated-string
optimization until we make up our minds later.
Marvin Humphrey
