On Mon, May 20, 2013 at 12:09 PM,  <[email protected]> wrote:

> Add parcel prefix to parcel.c and parcel.h
>
> The parcel header file must be publicly available, so add parcel prefix
> to avoid name clashes.

> Project: http://git-wip-us.apache.org/repos/asf/lucy/repo
> Commit: http://git-wip-us.apache.org/repos/asf/lucy/commit/fd43a656
> Tree: http://git-wip-us.apache.org/repos/asf/lucy/tree/fd43a656
> Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/fd43a656

> -    scratch = chaz_Util_join(dir_sep, "autogen", "source", "parcel.c", NULL);
> +    scratch = chaz_Util_join(dir_sep, "autogen", "source", "lucy_parcel.c",
> +                             NULL);

This bugs me because it's not extendable to fully qualified parcel namespaces,
but it's suggested a tangential idea:

How about eliminating the "autogen" directory and having all our output go
into .h files?  Then we can drop them alongside the .cfh files we used to
generate them.

  core/Lucy/Search/IndexSearcher.cfh  // in
  core/Lucy/Search/IndexSearcher.h    // out

There's a certain amount of tangible .c code that we generate, but maybe we
can stick that in a .h file and enclose it with ifdefs which only one .c file
defines.

    #ifdef C_LUCY_INDEXSEARCHER
    // ....
    #endif

The rationale is to make the connection between the .cfh source files and the
generated .h files clearer so that it's easier to for both newcomers and
experts to see what's going on.

Marvin Humphrey

Reply via email to